ci(release): add GitHub Release creation on tag releases#5
ci(release): add GitHub Release creation on tag releases#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa2c5d71dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Create GitHub Release | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
On tag pushes, this step executes before Publish To npm, so a failing npm publish (for example, an expired NPM_TOKEN or an already-published version) still leaves behind a GitHub Release and attached tarball for a version that is not actually available on npm. Reordering release creation to run after successful publish (or explicitly gating it on publish success) avoids publishing misleading release artifacts.
Useful? React with 👍 / 👎.
1 participant
Context
Release workflow was publishing to npm but not creating a GitHub Release artifact page.
Summary
contents: write+id-token: writein release workflowpackage.jsonon tag releasesnpm packduring releasesoftprops/action-gh-release) with generated notes and attached.tgzValidation