feat(app): add confirmation dialog before archiving session#24354
Open
herjarsa wants to merge 6 commits intoanomalyco:devfrom
Open
feat(app): add confirmation dialog before archiving session#24354herjarsa wants to merge 6 commits intoanomalyco:devfrom
herjarsa wants to merge 6 commits intoanomalyco:devfrom
Conversation
- Add SIGTERM handler in exit.tsx alongside existing SIGHUP handler - Add SIGTERM handler in thread.ts to gracefully stop worker - Add Effect.ensuring to abort AbortController in prompt.ts execRead - Replace unbounded Map with LRU cache in instance.ts (max 20 entries) Fixes anomalyco#15348 This addresses the critical issue where: 1. Processes spawned by opencode on Linux become orphaned when terminal closes 2. AbortController instances accumulate in session prompts causing heap growth 3. Instance cache grows without bound holding references to contexts Closes anomalyco#15348
…t_id not in stream When filterCompacted encounters a compaction part with tail_start_id pointing to a message older than available history, it previously included ALL messages in the result, causing context to inflate to 1.7M tokens instead of ~161k. This fix: 1. Tracks all messages in an 'all' array during iteration 2. When retain is set but not found, returns only the recent messages after retain was encountered (all.slice(-result.length)), not everything 3. Adds safety check in compaction.ts to skip overflow mode when selected.head is empty (which indicates tail_start_id is not in available history) Fixes anomalyco#24249
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, here are potential related PRs (excluding the current PR #24354): Related PRs:
These PRs are related to session archiving features but don't appear to be exact duplicates of the confirmation dialog feature. PR #24354 specifically adds a confirmation dialog before archiving (similar to |
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 26, 2026
- sst/opencode #24354 archive-confirmation dialog (request-changes: 6k lines of personal-tooling cruft + unrelated drive-bys + duplicated dialog component) - openai/codex #19650 AgentIdentity JWT verification (merge-after-nits: JWKS URL hardening, caching policy, nbf/max-lifetime/typ checks, typed init error) - aider #5052 bash repomap support (merge-as-is: strictly additive tree-sitter tags following established pattern)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Agrega diálogo de confirmación antes de archivar una sesión desde el timeline de mensajes. Sigue el mismo patrón que
DialogDeleteSessionque ya existía.How did you verify your code works?
TypeScript check passed (
bun tsc --noEmit).Screenshots / recordings
El diálogo muestra el nombre de la sesión y pide confirmación antes de archivar.
Checklist