Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/app/src/context/global-sync.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe("pickDirectoriesToEvict", () => {

describe("loadRootSessionsWithFallback", () => {
test("uses limited roots query when supported", async () => {
const calls: Array<{ directory: string; roots: true; limit?: number }> = []
const calls: Array<{ directory?: string; roots: true; limit?: number }> = []

const result = await loadRootSessionsWithFallback({
directory: "dir",
Expand All @@ -42,7 +42,7 @@ describe("loadRootSessionsWithFallback", () => {
})

test("falls back to full roots query on limited-query failure", async () => {
const calls: Array<{ directory: string; roots: true; limit?: number }> = []
const calls: Array<{ directory?: string; roots: true; limit?: number }> = []

const result = await loadRootSessionsWithFallback({
directory: "dir",
Expand All @@ -61,6 +61,22 @@ describe("loadRootSessionsWithFallback", () => {
{ directory: "dir", roots: true },
])
})

test("omits directory filter for project-wide loads", async () => {
const calls: Array<{ directory?: string; roots: true; limit?: number }> = []

await loadRootSessionsWithFallback({
directory: "dir",
filterDirectory: false,
limit: 10,
list: async (query) => {
calls.push(query)
return { data: [] }
},
})

expect(calls).toEqual([{ roots: true, limit: 10 }])
})
})

describe("estimateRootSessionTotal", () => {
Expand Down
17 changes: 11 additions & 6 deletions packages/app/src/context/global-sync.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ type GlobalStore = {
}

export const loadSessionsQuery = (directory: string) =>
queryOptions<null>({ queryKey: [directory, "loadSessions"], queryFn: skipToken })
queryOptions<null>({ queryKey: [directory, "loadSessions", true], queryFn: skipToken })

const sessionLoadQuery = (directory: string, filterDirectory: boolean) =>
queryOptions<null>({ queryKey: [directory, "loadSessions", filterDirectory], queryFn: skipToken })

function createGlobalSync() {
const globalSDK = useGlobalSDK()
Expand All @@ -52,7 +55,7 @@ function createGlobalSync() {
const sdkCache = new Map<string, OpencodeClient>()
const booting = new Map<string, Promise<void>>()
const sessionLoads = new Map<string, Promise<void>>()
const sessionMeta = new Map<string, { limit: number }>()
const sessionMeta = new Map<string, { filterDirectory: boolean; limit: number }>()

const [globalStore, setGlobalStore] = createStore<GlobalStore>({
ready: false,
Expand Down Expand Up @@ -146,14 +149,15 @@ function createGlobalSync() {
return sdk
}

async function loadSessions(directory: string) {
async function loadSessions(directory: string, options?: { filterDirectory?: boolean }) {
const filterDirectory = options?.filterDirectory ?? true
const pending = sessionLoads.get(directory)
if (pending) return pending

children.pin(directory)
const [store, setStore] = children.child(directory, { bootstrap: false })
const meta = sessionMeta.get(directory)
if (meta && meta.limit >= store.limit) {
if (meta && meta.filterDirectory === filterDirectory && meta.limit >= store.limit) {
const next = trimSessions(store.session, {
limit: store.limit,
permission: store.permission,
Expand All @@ -169,10 +173,11 @@ function createGlobalSync() {
const limit = Math.max(store.limit + SESSION_RECENT_LIMIT, SESSION_RECENT_LIMIT)
const promise = queryClient
.fetchQuery({
...loadSessionsQuery(directory),
...sessionLoadQuery(directory, filterDirectory),
queryFn: () =>
loadRootSessionsWithFallback({
directory,
filterDirectory,
limit,
list: (query) => globalSDK.client.session.list(query),
})
Expand All @@ -199,7 +204,7 @@ function createGlobalSync() {
setStore("session", reconcile(sessions, { key: "id" }))
cleanupDroppedSessionCaches(store, setStore, sessions, setSessionTodo)
})
sessionMeta.set(directory, { limit })
sessionMeta.set(directory, { filterDirectory, limit })
})
.catch((err) => {
console.error("Failed to load sessions", err)
Expand Down
10 changes: 8 additions & 2 deletions packages/app/src/context/global-sync/session-load.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
import type { RootLoadArgs } from "./types"

export async function loadRootSessionsWithFallback(input: RootLoadArgs) {
const query = (limit?: number) => ({
...(input.filterDirectory === false ? {} : { directory: input.directory }),
roots: true as const,
...(limit ? { limit } : {}),
})

try {
const result = await input.list({ directory: input.directory, roots: true, limit: input.limit })
const result = await input.list(query(input.limit))
return {
data: result.data,
limit: input.limit,
limited: true,
} as const
} catch {
const result = await input.list({ directory: input.directory, roots: true })
const result = await input.list(query())
return {
data: result.data,
limit: input.limit,
Expand Down
3 changes: 2 additions & 1 deletion packages/app/src/context/global-sync/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,9 @@ export type DisposeCheck = {

export type RootLoadArgs = {
directory: string
filterDirectory?: boolean
limit: number
list: (query: { directory: string; roots: true; limit?: number }) => Promise<{ data?: Session[] }>
list: (query: { directory?: string; roots: true; limit?: number }) => Promise<{ data?: Session[] }>
}

export type RootLoadResult = {
Expand Down
10 changes: 6 additions & 4 deletions packages/app/src/pages/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1824,10 +1824,12 @@ export default function Layout(props: ParentProps) {
return
}

const next = new Set(dirs)
for (const directory of next) {
if (loadedSessionDirs.has(directory)) continue
void globalSync.project.loadSessions(directory)
const filterDirectory = workspaceSetting()
const next = new Set(dirs.map((directory) => `${directory}\n${filterDirectory}`))
for (const directory of dirs) {
const key = `${directory}\n${filterDirectory}`
if (loadedSessionDirs.has(key)) continue
void globalSync.project.loadSessions(directory, { filterDirectory })
}

loadedSessionDirs.clear()
Expand Down
Loading