Skip to content

fix: move session roots filter from client-side to SQL layer #24383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heimoshuiyu wants to merge 2 commits into from
+3 −3
Closed

fix: move session roots filter from client-side to SQL layer #24383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16fa43f
fix: move session roots filter to SQL layer to prevent child sessions…
heimoshuiyu Apr 25, 2026
b6af6ca
fix: restore client-side parentID filter to guard against realtime su…
heimoshuiyu Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opencode/src/cli/cmd/tui/component/dialog-session-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function DialogSessionList() {

const [searchResults, { refetch }] = createResource(search, async (query) => {
if (!query) return undefined
const result = await sdk.client.session.list({ search: query, limit: 30 })
const result = await sdk.client.session.list({ search: query, limit: 30, roots: true })
return result.data ?? []
})

Expand Down
4 changes: 2 additions & 2 deletions packages/opencode/src/cli/cmd/tui/context/sync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
}
const start = Date.now() - 30 * 24 * 60 * 60 * 1000
const sessionListPromise = sdk.client.session
.list({ start: start })
.list({ start: start, roots: true })
.then((x) => (x.data ?? []).toSorted((a, b) => a.id.localeCompare(b.id)))

// blocking - include session.list when continuing a session
Expand Down Expand Up @@ -482,7 +482,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
async refresh() {
const start = Date.now() - 30 * 24 * 60 * 60 * 1000
const list = await sdk.client.session
.list({ start })
.list({ start, roots: true })
.then((x) => (x.data ?? []).toSorted((a, b) => a.id.localeCompare(b.id)))
setStore("session", reconcile(list))
},
Expand Down
Loading