feat(tui): add unified task state color convention with icons#24406
Open
herjarsa wants to merge 8 commits intoanomalyco:devfrom
Open
feat(tui): add unified task state color convention with icons#24406herjarsa wants to merge 8 commits intoanomalyco:devfrom
herjarsa wants to merge 8 commits intoanomalyco:devfrom
Conversation
- Add STATUS_COLORS constant with 6 states: running, waiting, attention, error, done, idle - Each state includes color (ISO 3864 based), icon, and text for WCAG 1.4.1 compliance - Add StatusIndicator, ProjectStatusBadge, SessionStateBanner components - Update ToastShow event to include projectName for multi-project notifications - Update Toast component to display project name and use status colors Closes anomalyco#24404
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
Why it's related: PR #24369 appears to be the actual implementation of model fallback functionality (handling APIError retries, error classification, fallbackModels chain). The current PR #24406's description mentions these exact features (fallback triggered on retryable APIError, no fallback on AuthError, resolveFallbackChain helper, etc.), but the PR title claims to be about "unified task state color convention with icons" which is a TUI feature. This mismatch suggests PR #24406 may have copied the description from PR #24369, making it a duplicate or a misdescribed PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24404
Type of change
What does this PR do?
Adds a unified task state color convention with icons for visual notifications in the TUI.
Color scheme:
success: Green (#22c55e) - Used for completed states, confirmationserror: Red (#ef4444) - Used for errors, failures, rejected stateswarning: Amber (#f59e0b) - Used for warnings, pending, in-progress statesinfo: Blue (#3b82f6) - Used for informational notificationsIcons used:
✓success✗error⚠warningℹinfoImplementation details:
status-colors.tswith centralized color and icon definitionsstatus-indicator.tsxcomponent for reusable status displayevent.tsto use status colors for user notificationstoast.tsxto apply consistent color stylingprompt/index.tsxto use status colors for message type indicatorsI understand why these changes work: centralized color definitions ensure consistency across the TUI, and the icon + color combination provides clear visual feedback for different task states.
How did you verify your code works?
bun typecheckpasses with zero errors in modified filesScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist