fix(server): share listener memo map#32113
Open
rekram1-node wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the process-shared Effect memo map when building the TCP listener instead of creating a fresh memo map per listener. This lets the TCP listener and in-process HTTP handler resolve shared application services from the same layer cache.
Verification
bun typecheckfrompackages/opencode: passedbun test test/server/httpapi-listen.test.ts: failed locally (4 passed, 6 failed) with listener auth/config leakage symptoms, including unexpected 401/404 responses and shutdown/WebSocket timeoutsThis is intentionally the minimal memo-map change so CI can expose its impact without additional refactoring.