fix: Windows compatibility for UTF-8 output and Rich console#35
Open
JohnFiedler wants to merge 1 commit intoanshumanbh:mainfrom
Open
fix: Windows compatibility for UTF-8 output and Rich console#35JohnFiedler wants to merge 1 commit intoanshumanbh:mainfrom
JohnFiedler wants to merge 1 commit intoanshumanbh:mainfrom
Conversation
On Windows, emoji and special characters in scan output cause encoding errors. This adds UTF-8 stream wrappers and force_terminal=True for Rich Console to ensure correct rendering on Windows terminals. Also fixes artifact regeneration to always run (not just when DAST is enabled), which is required for 'securevibes report' to work correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
@JohnFiedler Thank you for the PR. I pushed a bunch of changes introducing a new "pr-review" command. As a result of that, this PR has some conflicts. Do you mind taking a look at them and resolving them before I can review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.TextIOWrapper) forsys.stdout/sys.stderron Windows to handle emojis and special characters in scan outputConsole(force_terminal=True)for Rich console instances to ensure correct rendering on Windows terminalssecurevibes reportoutput on all platformsFiles changed
packages/core/securevibes/cli/main.py— UTF-8 wrapper + force_terminalpackages/core/securevibes/scanner/scanner.py— UTF-8 wrapper + force_terminal + always regenerate artifacts + conditional debug messagepackages/core/securevibes/scanner/subagent_manager.py— UTF-8 wrapper + force_terminalpackages/core/tests/test_scan_output.py— Test for evidence as list of dictsTest plan
securevibes scanon Windows and verify emoji/special characters render correctlysecurevibes reportafter a scan and verify artifacts are generatedpytest packages/core/tests/🤖 Generated with Claude Code