Fix based on AAH recomendations#29
Open
hcherukuri wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the review I identified issues that prevent certification of this version.
Please address the following issues and resubmit.
[requirements.txt] Contains 'ansible-core>=2.16.0'. requirements.txt MUST
NOT include 'ansible' or 'ansible-core'. ansible-core is provided by the
Execution Environment.
[requirements.txt] Contains 'setuptools>=70.0.0,<81.0.0' with a capped
upper bound. Capped versions break EE builds when collections have
conflicting version requirements. Remove the upper bound.
Note: The requirements.txt appears to be a documentation build requirements file (contains sphinx, antsibull, etc.) rather than a runtime dependency file. If the collection doesn't need any of these dependencies at runtime, then it is recommended to move them to a file such as
docs-requirements.txtor similar so they are not automatically picked up by Ansible Builder.