Skip to content

Fix other duplicate Jinja2 closing tags#336

Open
dsavineau wants to merge 1 commit intoansible:mainfrom
dsavineau:other_jinja2_syntax_issues
Open

Fix other duplicate Jinja2 closing tags#336
dsavineau wants to merge 1 commit intoansible:mainfrom
dsavineau:other_jinja2_syntax_issues

Conversation

@dsavineau
Copy link
Copy Markdown
Contributor

@dsavineau dsavineau commented Apr 9, 2026

This was done in ccccc99 for the activation worker deployment but the issue is also present in the default worker and ui deployment templates

Summary by CodeRabbit

  • Bug Fixes
    • Corrected template syntax formatting in deployment configuration files to ensure proper parsing.

This was done in ccccc99 for the activation worker deployment but the
issue is also present in the default worker and ui deployment templates

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 631122fa-4345-44db-bb2f-0821d5ad8cd5

📥 Commits

Reviewing files that changed from the base of the PR and between ccccc99 and 5183504.

📒 Files selected for processing (2)
  • roles/eda/templates/eda-default-worker.deployment.yaml.j2
  • roles/eda/templates/eda-ui.deployment.yaml.j2

📝 Walkthrough

Walkthrough

Two Kubernetes deployment Jinja templates have corrected conditional syntax by removing extraneous closing brace sequences from topology_spread_constraints conditionals, fixing template parsing without changing rendered output.

Changes

Cohort / File(s) Summary
Jinja Template Syntax Fixes
roles/eda/templates/eda-default-worker.deployment.yaml.j2, roles/eda/templates/eda-ui.deployment.yaml.j2
Removed extra whitespace-trimming marker (%}) from conditional statements affecting topology_spread_constraints blocks. Changed {% if ... is defined %} %} to {% if ... is defined %}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing duplicate Jinja2 closing tags in deployment templates, which matches the file modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants