Skip to content

fix(deps): add dynaconf >= 3.2.13 (CVE-2026-33154)#1526

Merged
B-Whitt merged 1 commit intoansible:mainfrom
B-Whitt:fix/cve-2026-33154-dynaconf
Apr 13, 2026
Merged

fix(deps): add dynaconf >= 3.2.13 (CVE-2026-33154)#1526
B-Whitt merged 1 commit intoansible:mainfrom
B-Whitt:fix/cve-2026-33154-dynaconf

Conversation

@B-Whitt
Copy link
Copy Markdown
Contributor

@B-Whitt B-Whitt commented Apr 13, 2026

Summary

  • Remediates CVE-2026-33154: arbitrary code execution via SSTI in dynaconf's @Jinja resolver (CVSS 7.5 HIGH)
  • Adds dynaconf as direct dependency (was transitive via django-ansible-base at 3.2.10)

Ref: AAP-69465

Summary by CodeRabbit

  • Chores
    • Added the dynaconf dependency (>=3.2.13) to the project dependencies.
    • No other dependency entries, metadata, scripts, or tool configurations were modified in this update.

@B-Whitt B-Whitt requested a review from a team as a code owner April 13, 2026 12:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b26612b-a08a-486e-88b4-745650473268

📥 Commits

Reviewing files that changed from the base of the PR and between c6a7d37 and 53d3ecf.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

Added a new dependency entry: dynaconf with version constraint >=3.2.13 to pyproject.toml. No other dependencies, metadata, tool configuration, or scripts were changed.

Changes

Cohort / File(s) Summary
Dependency Addition
pyproject.toml
Added dynaconf >=3.2.13 as a new project dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a dependency fix for a CVE vulnerability, which is the main change in the PR.
Description check ✅ Passed The description covers the key aspects: what CVE is being addressed, why it's needed, and what's being changed. It includes a reference to the tracking issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ttuffin
Copy link
Copy Markdown
Contributor

ttuffin commented Apr 13, 2026

/run-e2e

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 46: The project adds dynaconf = ">=3.2.13" in pyproject.toml which
conflicts with the pinned dynaconf ==3.2.12 in the django-ansible-base devel
branch (requirements/requirements_all.txt), preventing resolution; to fix,
coordinate with or update django-ansible-base to relax or bump its dynaconf pin
to >=3.2.13 (or remove the strict ==3.2.12), then re-run dependency resolution
so pyproject.toml's dynaconf >=3.2.13 can be applied; reference the dynaconf
entry in pyproject.toml and the dynaconf pin in
requirements/requirements_all.txt (django-ansible-base) when making the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 191d5ed6-83fa-4f62-96e4-b5320baa0dcb

📥 Commits

Reviewing files that changed from the base of the PR and between bf5aca0 and c6a7d37.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

@ptoscano
Copy link
Copy Markdown
Contributor

/run-e2e

@github-actions github-actions bot deployed to e2e-tests April 13, 2026 12:39 Active
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (af39a9f) to head (53d3ecf).

@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         239      239           
  Lines       10810    10810           
=======================================
  Hits         9938     9938           
  Misses        872      872           
Flag Coverage Δ
unit-int-tests-3.11 91.93% <ø> (ø)
unit-int-tests-3.12 91.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful e2e run: https://github.com/ansible/eda-server/actions/runs/24343812401

Also please check the feedback of coderabbit, in particular what DAB uses/pins, and in case check with the DAB folks too.

Copy link
Copy Markdown
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

SSTI via unsafe Jinja2 template evaluation in the @Jinja resolver.
Adds dynaconf as a direct dependency to force upgrade from 3.2.10.

Ref: AAP-69465

Assisted by: Claude Code
@B-Whitt B-Whitt force-pushed the fix/cve-2026-33154-dynaconf branch from c6a7d37 to 53d3ecf Compare April 13, 2026 15:53
@sonarqubecloud
Copy link
Copy Markdown

@B-Whitt B-Whitt merged commit 8d5398e into ansible:main Apr 13, 2026
8 of 12 checks passed
@B-Whitt B-Whitt deleted the fix/cve-2026-33154-dynaconf branch April 13, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants