Add Guard Statement to large number.#54
Open
yeguang-xue wants to merge 5 commits into
Open
Conversation
For number like 1.0E28, it crashes on MacOS -- due to buffer overflow.
Collaborator
|
That change looks ok - but we need a test case to cover it. |
Collaborator
|
@cla-bot rerun |
|
The following people have not signed the Contributors License Agreement (CLA): Read the CLA in the link above and sign it by clicking below: You will receive a confirmation as soon as your signature is captured. Note Action Required: Repository maintainers with write access can trigger a recheck by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For number like 1.0E28, it crashes on MacOS due to buffer overflow (but linux/windows seems to be fine, maybe Mac has more strict memory check). E.g. the following statement will fail:
Unfortunately some LS-Dyna Keyword Cards have default values 1e28.