feat(mpv): video output levels override#167
Draft
plyrthn wants to merge 1 commit into
Draft
Conversation
Owner
|
thank you @plyrthn! re: "P.S. I'm sorry for the 5 PRs I just felt it was better to do each feature as a single PR " I'll apologize right back though because i'll not likely get time to review each of these till some time this weekend. I hope that's ok and thank you working on these. Sorry for my delay. |
Contributor
Author
|
Hey no worries!! Take your time friend!!! :) I LOVE this project and it looks like a DREAM on my trinitron! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Video Levels" setting (Auto/Limited/Full) that overrides mpv's
auto-detected output color range. Auto trusts the source file's tagged
range, same as today; Limited/Full let you force it if content looks washed
out or crushed on a given display regardless of what the file is tagged as.
Files:
views/Settings.qml,src/player/MpvController.cppP.S. I'm sorry for the 5 PRs I just felt it was better to do each feature as a single PR :)
Testing
Confirmed each of the three options changes mpv's output range as expected.
Not tested on macOS.
Checklist
root.sh&root.swproperties (did not hardcode pixels) and kept CRT overscan in mind