Skip to content

fix: setting_sources=[] bug (issue #794) #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanookclaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: setting_sources=[] bug (issue #794) #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/claude_agent_sdk/_internal/transport/subprocess_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,11 @@ def _build_command(self) -> list[str]:
# Agents are always sent via initialize request (matching TypeScript SDK)
# No --agents CLI flag needed

if self._options.setting_sources:
cmd.extend(["--setting-sources", ",".join(self._options.setting_sources)])
if self._options.setting_sources is not None:
if len(self._options.setting_sources) == 0:
cmd.extend(["--setting-sources", ""])
else:
cmd.extend(["--setting-sources", ",".join(self._options.setting_sources)])

# Add plugin directories
if self._options.plugins:
Expand Down
8 changes: 5 additions & 3 deletions tests/test_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,14 +436,16 @@ def test_build_command_setting_sources_omitted_when_not_provided(self):
cmd = transport._build_command()
assert "--setting-sources" not in cmd

def test_build_command_setting_sources_omitted_when_empty(self):
"""Test that --setting-sources is omitted when setting_sources is empty list."""
def test_build_command_setting_sources_empty_list_passes_empty_string(self):
"""Test that --setting-sources passes empty string when setting_sources is empty list."""
transport = SubprocessCLITransport(
prompt="test",
options=make_options(setting_sources=[]),
)
cmd = transport._build_command()
assert "--setting-sources" not in cmd
assert "--setting-sources" in cmd
idx = cmd.index("--setting-sources")
assert cmd[idx + 1] == ""

def test_build_command_setting_sources_included_when_provided(self):
"""Test that --setting-sources is included when setting_sources has values."""
Expand Down