feat(transport): expose subprocess PID for external cleanup#818
Open
SAY-5 wants to merge 1 commit intoanthropics:mainfrom
Open
feat(transport): expose subprocess PID for external cleanup#818SAY-5 wants to merge 1 commit intoanthropics:mainfrom
SAY-5 wants to merge 1 commit intoanthropics:mainfrom
Conversation
Per anthropics/anthropic-sdk-python#1370, callers that need to forcibly clean up the spawned `claude` CLI process (timeouts, hard shutdowns, parent-process cleanup) currently have to walk async generator internals to find the process, which is fragile and depends on SDK private state. Add a public `pid` property on `SubprocessCLITransport` that returns the underlying process PID, or `None` if no process is currently running. The existing `close()` already implements the graceful-shutdown → SIGTERM → SIGKILL escalation requested in the issue, so this PR only adds the PID accessor. Closes anthropics/anthropic-sdk-python#1370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per anthropics/anthropic-sdk-python#1370, callers that need to forcibly clean up the spawned
claudeCLI process (timeouts, hard shutdowns, parent-process cleanup) currently have to walk async generator internals to find the process, which is fragile and depends on SDK private state.This PR adds a public
pidproperty onSubprocessCLITransportthat returns the underlying process PID, orNoneif no process is currently running. The existingclose()already implements the graceful-shutdown → SIGTERM → SIGKILL escalation requested in the issue, so this PR only adds the PID accessor.Closes anthropics/anthropic-sdk-python#1370