Skip to content

fix(config): parse selected fields safely when names contain spaces #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitksingh1490 merged 1 commit into from
Apr 7, 2026
+16 −4
Merged

fix(config): parse selected fields safely when names contain spaces #2883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shell-plugin/lib/actions/auth.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ function _forge_action_login() {
selected=$(_forge_select_provider "" "" "" "$input_text")
if [[ -n "$selected" ]]; then
# Extract the second field (provider ID)
# Use multi-space delimiter to handle display names containing spaces
local provider=$(echo "$selected" | awk -F ' +' '{print $2}')
_forge_exec_interactive provider login "$provider"
fi
Expand All @@ -25,6 +26,7 @@ function _forge_action_logout() {
selected=$(_forge_select_provider "\[yes\]" "" "" "$input_text")
if [[ -n "$selected" ]]; then
# Extract the second field (provider ID)
# Use multi-space delimiter to handle display names containing spaces
local provider=$(echo "$selected" | awk -F ' +' '{print $2}')
_forge_exec provider logout "$provider"
fi
Expand Down
18 changes: 14 additions & 4 deletions shell-plugin/lib/actions/config.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ function _forge_action_model() {
# Field 1 = model_id (raw), field 3 = provider display name,
# field 4 = provider_id (raw, for config set)
local model_id provider_display provider_id
read -r model_id provider_display provider_id <<<$(echo "$selected" | awk -F ' +' '{print $1, $3, $4}')
# Extract fields separately to handle display names with spaces
model_id=$(echo "$selected" | awk -F ' +' '{print $1}')
provider_display=$(echo "$selected" | awk -F ' +' '{print $3}')
provider_id=$(echo "$selected" | awk -F ' +' '{print $4}')
model_id=${model_id//[[:space:]]/}
provider_id=${provider_id//[[:space:]]/}
provider_display=${provider_display//[[:space:]]/}
Expand Down Expand Up @@ -179,7 +182,9 @@ function _forge_action_commit_model() {
if [[ -n "$selected" ]]; then
# Field 1 = model_id (raw), field 4 = provider_id (raw)
local model_id provider_id
read -r model_id provider_id <<<$(echo "$selected" | awk -F ' +' '{print $1, $4}')
# Extract fields separately to handle display names with spaces
model_id=$(echo "$selected" | awk -F ' +' '{print $1}')
provider_id=$(echo "$selected" | awk -F ' +' '{print $4}')

model_id=${model_id//[[:space:]]/}
provider_id=${provider_id//[[:space:]]/}
Expand Down Expand Up @@ -208,7 +213,9 @@ function _forge_action_suggest_model() {
if [[ -n "$selected" ]]; then
# Field 1 = model_id (raw), field 4 = provider_id (raw)
local model_id provider_id
read -r model_id provider_id <<<$(echo "$selected" | awk -F ' +' '{print $1, $4}')
# Extract fields separately to handle display names with spaces
model_id=$(echo "$selected" | awk -F ' +' '{print $1}')
provider_id=$(echo "$selected" | awk -F ' +' '{print $4}')

model_id=${model_id//[[:space:]]/}
provider_id=${provider_id//[[:space:]]/}
Expand Down Expand Up @@ -328,7 +335,10 @@ function _forge_action_session_model() {

if [[ -n "$selected" ]]; then
local model_id provider_display provider_id
read -r model_id provider_display provider_id <<<$(echo "$selected" | awk -F ' +' '{print $1, $3, $4}')
# Extract fields separately to handle display names with spaces
model_id=$(echo "$selected" | awk -F ' +' '{print $1}')
provider_display=$(echo "$selected" | awk -F ' +' '{print $3}')
provider_id=$(echo "$selected" | awk -F ' +' '{print $4}')
model_id=${model_id//[[:space:]]/}
provider_id=${provider_id//[[:space:]]/}

Expand Down
Loading