[codex] Make seeded tool IDs deterministic#115
Open
audreyt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seeded requests were still not fully reproducible when the model emitted tool calls, because ds4-server generated missing OpenAI/Anthropic tool call IDs with random bytes after decoding. That meant otherwise identical seeded runs could differ in
call_.../toolu_...identifiers, making decision traces noisy to replay and diff.This changes missing tool ID generation so that requests with a positive
seedderive deterministic IDs from the request context, API style, tool index, and tool name. Unseeded requests keep the existing random ID path. OpenAI live tool streaming now uses the same deterministic ID path, so the streamed tool-call start delta and the final parsed tool call agree.Impact
Validation
Passing locally on Apple M5 Max:
./ds4_test --server./ds4_test --tool-call-qualityAlso ran full
make testagainst this upstream-based branch. It currently fails in my checkout on pre-existing long-context/logprob vector expectation mismatches with the local model/fixtures, whiletool-call-quality,metal-kernels, andserverpass. The new deterministic-ID test is part of the--servergroup above.