fix: remove 1px bottom border line from header#19
Draft
anton-patrushev wants to merge 2 commits into
Draft
Conversation
…lumn On Android the final onScroll event fires fractionally before the snap target settles, so Math.floor was resolving to the previous page index and placing the drag indicator in the wrong resource column. Switching to Math.round makes the fractional offset round to the nearest column, and an additional clamp(0, resourcePerPage-1) guards against any out-of-bounds index that could still slip through.
The default 1px grey border at the bottom of the header container is not desirable. Set borderBottomWidth to 0 so consumers can style the header border via the theme/style props if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
borderBottomWidth: 0so consumers can style the header border via theme/style props if neededTest plan
🤖 Generated with Claude Code