fix(drag-n-drop): account for zoomScale in vertical autoscroll#34
Draft
sgandhi-gg wants to merge 1 commit into
Draft
fix(drag-n-drop): account for zoomScale in vertical autoscroll#34sgandhi-gg wants to merge 1 commit into
sgandhi-gg wants to merge 1 commit into
Conversation
The auto-scroll-during-drag computed `maxOffsetY` from unscaled `timelineHeight`, but the underlying ScrollView content height is `timelineHeight * zoomScale` (set by CalendarBody's outer spacer). At zoom > 1, downward auto-scroll clamped to the unzoomed bottom and stopped roughly half-way through the visible content. The minutes-per-pixel divisor used during auto-scroll also ignored `zoomScale`, so the dragged event's time shifted faster than the finger at higher zoom levels. Pull `zoomScale` from `useCalendar()` and apply it to both `maxOffsetY` and the `diffY → minutes` conversion (matching the conversion already used elsewhere in CalendarContainer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #33.
The
DragEventProviderauto-scroll-during-drag computesmaxOffsetYfrom the unscaledtimelineHeight, but the ScrollView's outer-spacer content height istimelineHeight * zoomScale(set inCalendarBody). At zoom > 1, downward auto-scroll clamps to the unzoomed bottom and stops roughly half-way through the visible content. ThediffY → minutesconversion during auto-scroll also ignoreszoomScale, so the dragged event's time shifts faster than the finger at higher zoom levels.Changes
zoomScalefromuseCalendar()inDragEventProvidermaxOffsetY = timelineHeight.value * zoomScale.value - scrollVisibleHeightAnim.valueminutes = diffY / (minuteHeight.value * zoomScale.value)(matches the conversion already used inCalendarContainer.tsx)Test plan