feat: add state management by ayogun · Pull Request #1 · antonbabenko/terraform-skill

ayogun · 2026-01-20T04:12:43Z

Pull Request

Description

Type of change:

New content (adding best practices, patterns, or guidance)
Fix (correcting outdated or incorrect information)
Refactor (reorganizing or improving clarity)
Documentation (README, CONTRIBUTING, etc.)
Testing framework improvement

Summary:

Testing Evidence (REQUIRED)

Scenarios Tested

Scenario #: [Name]
Scenario #: [Name]

Baseline Behavior (WITHOUT changes)

Prompt: [test prompt]

Agent response: [verbatim or screenshot]

Issues:
- [What was missing or incorrect]

Compliance Behavior (WITH changes)

Prompt: [same test prompt]

Agent response: [verbatim or screenshot]

Improvements:
- [What improved]
- [Patterns now followed]

Evidence of Improvement

Agent references new content
Agent applies new patterns proactively
Agent doesn't rationalize skipping guidance
No new rationalizations introduced

Standards Compliance Checklist

Frontmatter (if SKILL.md changed)

Only name and description fields present
Description starts with "Use when..."
Description focuses on triggers/symptoms (not workflow summary)
Description < 1024 characters
Total frontmatter < 1024 characters
Name uses only letters, numbers, hyphens

Token Efficiency

SKILL.md remains <1,500 words (current: ~1,400)
Detailed content moved to skills/*.md reference files where appropriate
Used tables instead of prose
No content duplication

Content Quality

Imperative voice ("Use X", not "You should use X")
Scannable format (tables, bullets, clear headers)
Code examples are complete and runnable
Version-specific features clearly marked
✅ DO vs ❌ DON'T patterns where appropriate

File Organization

Core content in SKILL.md
Detailed guides in skills/*.md
Testing updates in tests/*.md
No new files outside standard structure

Validation

Frontmatter validation passes
File size within guidelines
No broken internal links
Markdown lint clean
No TODO/FIXME comments (or tracked in issues)

Rationalizations

New rationalizations discovered:

None discovered
Documented in tests/rationalization-table.md
- Rationalization: [verbatim agent excuse]
- Counter added: [how SKILL.md now addresses it]

Related Issues

Closes #
Relates to #

Additional Context

For Maintainers

Review Checklist

Testing evidence is convincing (baseline → compliance improvement shown)
Standards compliance verified
Content is accurate and current
Token efficiency maintained
Quality standards met
No conflicts with existing content
CHANGELOG.md updated (if needed)

Merge Checklist

Squash commits with clear commit message
Update CHANGELOG.md if not done in PR
Consider if version bump needed
Tag if this completes a planned milestone

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- Remove invalid terraform state mv command for moving between state files - Remove dangerous cleanup script with hardcoded LOCK_ID - Fix invalid backend_config block for Terraform Cloud lock timeout - Fix invalid string interpolation in backend configuration Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

SKILL.md

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

…ect Lock Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

antonbabenko

Awesome additions. The main concern I have is the level of detail in SKILL.md - it should be refactored. Important information from SKILL.md should go to references/.

antonbabenko · 2026-01-20T11:21:34Z

references/state-management.md

+- [Atlantis](https://www.runatlantis.io/) - Terraform automation with locking
+
+### Best Practices Guides
+- [terraform-best-practices.com - State Management](https://www.terraform-best-practices.com/state)


Suggested change

- [terraform-best-practices.com - State Management](https://www.terraform-best-practices.com/state)

There is no such page.

antonbabenko · 2026-01-20T11:27:31Z

SKILL.md

+
+**Use terraform_remote_state for component dependencies:**
+
+```hcl


Let's drop this code snippet since it is already well-known for LLMs.

antonbabenko · 2026-01-20T11:29:19Z

SKILL.md

+}
+```
+
+### Essential State Commands


Let's not have Terraform CLI commands in the SKILL.md itself, but have them in the quick-reference.md . They are there already, so drop this section from SKILL.md

antonbabenko · 2026-01-20T11:34:11Z

SKILL.md

+
+### State Locking
+
+**How it works:**


LLM already knows "HOW", we need to focus on concrete solutions/workarounds and decision-making processes. Let's drop section "### State Locking".

Copilot AI and others added 4 commits January 20, 2026 05:10

Add comprehensive state management guide and update documentation

d635471

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

Update documentation files to reflect state management addition

29c3f65

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

Update references/state-management.md

ebbf653

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mapu77 reviewed Jan 20, 2026

View reviewed changes

SKILL.md Outdated Show resolved Hide resolved

raven-soprano approved these changes Jan 20, 2026

View reviewed changes

Copilot AI and others added 3 commits January 20, 2026 11:43

Add Terraform 1.11+ S3 native lock-file documentation

b85f1d3

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

Fix parameter name: use_lock_file instead of use_lockfile

01293c6

Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

Fix: Correct S3 lock mechanism description - uses lock files, not Obj…

9edd4c3

…ect Lock Co-authored-by: ayogun <62607936+ayogun@users.noreply.github.com>

ayogun requested review from mapu77 and raven-soprano January 20, 2026 10:46

antonbabenko requested changes Jan 20, 2026

View reviewed changes

antonbabenko mentioned this pull request Jan 20, 2026

State lock does not require dynamo #2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add state management#1

feat: add state management#1
ayogun wants to merge 7 commits intoantonbabenko:masterfrom
ayogun:master

ayogun commented Jan 20, 2026

Uh oh!

Uh oh!

antonbabenko left a comment

Uh oh!

antonbabenko Jan 20, 2026

Uh oh!

antonbabenko Jan 20, 2026

Uh oh!

antonbabenko Jan 20, 2026

Uh oh!

antonbabenko Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		Use terraform_remote_state for component dependencies:

		```hcl

Conversation

ayogun commented Jan 20, 2026

Pull Request

Description

Testing Evidence (REQUIRED)

Scenarios Tested

Baseline Behavior (WITHOUT changes)

Compliance Behavior (WITH changes)

Evidence of Improvement

Standards Compliance Checklist

Frontmatter (if SKILL.md changed)

Token Efficiency

Content Quality

File Organization

Validation

Rationalizations

Related Issues

Additional Context

For Maintainers

Review Checklist

Merge Checklist

Uh oh!

Uh oh!

antonbabenko left a comment

Choose a reason for hiding this comment

Uh oh!

antonbabenko Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

antonbabenko Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

antonbabenko Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

antonbabenko Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants