fix(validate): catch unquoted YAML frontmatter that runtime drops#30
Open
mxl wants to merge 1 commit into
Open
fix(validate): catch unquoted YAML frontmatter that runtime drops#30mxl wants to merge 1 commit into
mxl wants to merge 1 commit into
Conversation
skill_validate accepted SKILL.md files with unquoted description values containing ': ' (colon-space). OpenCode runtime uses gray-matter → js-yaml which rejects these as malformed YAML mappings, silently dropping the skill from available skills. Add strict YAML parse check via the yaml package before structural validation. Returns clear error with line/column and quoting hint. Closes antongulin#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skill_validateaccepted SKILL.md files with unquoteddescription:values containing:(colon-space). OpenCode runtime usesgray-matter→js-yamlwhich rejects these as malformed YAML mappings, silently dropping the skill from available skills.Example that passed validation but failed at runtime:
Fix
Add strict YAML parse check via the
yamlpackage before structural validation invalidateSkill(). Returns clear error with line/column number and a hint to quote the value.Changes
plugin/lib/validate.ts— Importyaml.parseDocument, add frontmatter parse check after extractionplugin/package.json— Addyamlas explicit dependencyplugin/test/validate.test.ts— 11 regression tests covering valid quoted, invalid unquoted, and existing checksTest results
55/55 tests pass, build succeeds.