fix: highlight triggered while ime inputs are not committed#5
Open
kaaass wants to merge 1 commit intoantoniotejada:mainfrom
Open
fix: highlight triggered while ime inputs are not committed#5kaaass wants to merge 1 commit intoantoniotejada:mainfrom
kaaass wants to merge 1 commit intoantoniotejada:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The highlighting is wrongly triggered while IME inputs are not committed, which is a normal situation for CJK inputs. The current version will give a result like this:
This PR maintains a new state
inCompositioninHighlightCodeBlockWidgetby listeningcompositionstartandcompositionendevents, and ignores every changes fired between these events. The fix references facebook/react#3926 and ckeditor/ckeditor5#1342.