feat(hotkeys): reader reply/forward/yank/headers + trimmed g-leader#1
Merged
Conversation
…ilities Gmail does not advertise CONDSTORE in its CAPABILITY response but does return HIGHESTMODSEQ in SELECT replies and honours CHANGEDSINCE. The previous code used only the capability check, so it always fell back to a full UID SEARCH ALL on every sync. This meant messages that arrived between the CHANGEDSINCE check and the SEARCH ALL could be silently missed on that run. Fix: treat a present highest_modseq in the SELECT response as evidence of CONDSTORE support, enabling incremental delta sync for Gmail.
- proposal: three-state morphing UI (dot → button → spinner → popup) - design: state machine architecture, event log with localStorage persistence - specs: 18 requirements for compact UI and event log (40+ scenarios) - tasks: 42 implementation checkpoints across 9 phases - event log: 15 latest events displayed, 2000-line localStorage history
Implements the hotkeys-improvement OpenSpec change: - Reader actions: r (reply), R (reply-all), F (forward), y (yank body), Y (yank headers+body), g h (toggle headers menu). - Reader navigation leaders g f / g a (folder/account picker) so they work from the reader, not just the list. - List g-leader trimmed: remove g i/g s/g d/g A, rebind account picker to g a, keep g f/g g/G. - Backend: mailbrus-core gains split_address_list + Headers.cc; the message-detail response now emits structured to/cc for reply-all. - Pure reply.ts (Re:/Fwd: dedup, "> " quoting, reply-all dedup + own-address exclusion) + compose prefill via ui.composePrefill. - Scope-aware g-leader indicator (reader vs list). Validated: cargo (61) + deno unit (53) + e2e (156) all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
hotkeys-improvementOpenSpec change.Reader actions
rreply,Rreply-all,Fforward,yyank body,Yyank headers+body,g htoggle headers menu.g f/g aopen the folder / account picker from the reader (mirrors the list g-leader).List g-leader cleanup (BREAKING for muscle memory)
g i/g s/g d/g A; account picker reboundg A→g a; keptg f/g g/G.Backend
mailbrus-core:split_address_list+Headers.cc(with unit tests).mailbrus-server: message-detail response now emits structuredto/ccfor reply-all.Frontend
reply.ts(Re:/Fwd: dedup,>quoting, reply-all dedup + own-address exclusion), unit-tested.ui.composePrefill; scope-aware g-leader indicator.Validation