Fix issue preventing markdown rendering. Do not assume zsh for all unix users.#4
Open
gdelfino wants to merge 4 commits intoantononcube:mainfrom
Open
Fix issue preventing markdown rendering. Do not assume zsh for all unix users.#4gdelfino wants to merge 4 commits intoantononcube:mainfrom
gdelfino wants to merge 4 commits intoantononcube:mainfrom
Conversation
Do not assume that everyone is using zsh.
Always write mmdc input in a file, not just under Windows. When the mmdc input is sent as part of the command and not in a file, then the backticks (`) required to embed markdown are interpreted by the shell and never reach mmdc.
This flag was already being used for Mac/Unix but was not being used for Windows.
Owner
|
Thanks for working out those issues! I will review and merge today / this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a Unix based OS, diagrams with Markdown were failing. The backticks required by
mmdcwere being interpreted by the shell because the input was not in a file. Additionally, the default value forSessionPrologwas changed to depend on the value of theSHELLenvironmental variable.