Skip to content

Jess/381 pod linking#382

Open
jesscmoore wants to merge 6 commits into
devfrom
jess/381_pod_linking
Open

Jess/381 pod linking#382
jesscmoore wants to merge 6 commits into
devfrom
jess/381_pod_linking

Conversation

@jesscmoore

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

This allows a user logged in to their webid to view their webid file, eg jessicamoore/profile/card$.ttl and link another pod on another Solid server by temporarily adding the oidcRegistrationToken of server 2, and adding server 2 as a oidcIssuer.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Use notepod or other solid app, pointed to this branch of solidui

Checklist

  • Screenshots included here/in linked issue #SOLIDUI: allow linking a new pod to webid in profile settings #381
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore
jesscmoore requested a review from cdawei July 22, 2026 11:02
@cdawei

cdawei commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I followed these steps to test this PR.

  1. Register a CSS account, and create a POD (in section Pods, click the Create pod link, provide the POD name, and choose to use an external WebID, say WebID1).
image
  1. Link the WebID used in step 1 (i.e., WebID1) to the CSS account (in section Registered Web IDs of the above screenshot, click Link WebID), after clicking Link WebID to account`, a page with registration token is shown.
image
  1. Use a solidui based app, login with a CSS account linked with WebID1 (not the newly registered account), go to the profile page, click Link another Pod, and provide the POD server URL and the token from step 2, click Add Token. Then follow the on-screen instructions in the app to finishing the linking.
image
  1. After successfully linking WebID1 with a newly created POD (and the corresponding CSS account), one can then login a solidui based app using the new CSS account and WebID1.

@cdawei cdawei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality worked as expected in my test, as noted in this comment, thanks Jess.

One observation: The current implementation does not seem to check if a server has already been linked, so it's possible to link the same server multiple times (as shown in the screenshot below).

image

@cdawei
cdawei requested a review from tonypioneer July 24, 2026 02:31
@jesscmoore

Copy link
Copy Markdown
Collaborator Author

Thanks Dawei, the last commit should have prevented duplicate oidcIssuers, but looks like it didn't catch your use pattern. I'll check and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants