Add abort signal tests for transaction planner#657
Merged
lorisleiva merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
|
This was referenced Jul 14, 2025
Member
Author
BundleMonUnchanged files (130)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-nkub32eu7-anza-tech.vercel.app |
steveluscher
approved these changes
Jul 14, 2025
Contributor
There was a problem hiding this comment.
I was thinking of tests that went even deeper; I should have been more elaborate in my prior review.
Tests that assert, like, if I'm in the middle of creating a transaction message when the user aborts, that onTransactionMessageUpdated() never gets called. And on and on for all the various interruption points and the implication about what work should not get done.
lorisleiva
force-pushed
the
07-14-add_abort_signal_tests_for_transaction_planner
branch
from
82d2410 to
d07f072
Compare
Member
Author
Merge activity
|
lorisleiva
changed the base branch from
06-16-add_createbasetransactionplanner_function
to
graphite-base/657
lorisleiva
force-pushed
the
07-14-add_abort_signal_tests_for_transaction_planner
branch
from
d07f072 to
b0ea57a
Compare
lorisleiva
deleted the
07-14-add_abort_signal_tests_for_transaction_planner
branch
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to ensure the
TransactionPlannerimplementation can be aborted even if the provided config functions never resolve.