Skip to content

fix: surface actual session branch in frontend#358

Merged
areycruzer merged 1 commit into
mainfrom
codex/session-branch-display
Jun 21, 2026
Merged

fix: surface actual session branch in frontend#358
areycruzer merged 1 commit into
mainfrom
codex/session-branch-display

Conversation

@areycruzer

@areycruzer areycruzer commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose the persisted session branch as a display-safe branch field on SessionView
  • keep operational session metadata private while preserving the existing frontend synthetic fallback
  • regenerate the OpenAPI spec and frontend schema, with backend/frontend coverage for the branch mapping

Fixes #356

Notes

  • Rebase risk: feat(status): collapse session status to five glanceable states (#332) #349 is open and also touches frontend/src/renderer/hooks/useWorkspaceQuery.ts and frontend/src/renderer/hooks/useWorkspaceQuery.test.tsx, so whichever PR merges second may need a small rebase.
  • Test scope: this adds controller coverage for the list-session wire shape plus frontend mapper coverage. It does not add a full spawn-persist-read integration test; the shared sessionView helper also serves single-session responses, so the untested surface is small.

Tests

  • cd backend && go test ./...
  • npm --prefix frontend run test -- src/renderer/hooks/useWorkspaceQuery.test.tsx
  • npm --prefix frontend run typecheck
  • Manual dashboard smoke: launched Electron with isolated /tmp daemon state, seeded a temp session whose persisted branch is qa/modal-worker, verified the daemon API returned branch: "qa/modal-worker", and verified the dashboard board card plus session detail inspector displayed qa/modal-worker instead of session/branch-ui-1.

@areyswyam

Copy link
Copy Markdown

Dashboard smoke proof: real Electron dashboard session detail using isolated local daemon state. The seeded session displays the persisted branch qa/modal-worker in both the window topbar and the inspector Branch row.

electron-window-proof

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@areycruzer areycruzer merged commit 34a9fdb into main Jun 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session detail shows synthetic branch instead of actual worker branch

3 participants