fix(frontend): require node 20 for electron dev#413
Open
anirudh5harma wants to merge 1 commit into
Open
Conversation
69109d8 to
7c7c985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #412
Problem
The Electron frontend is effectively Node-20-only today, but contributors are
not told that up front. On Node 24/26, upstream Electron/Electron Forge install
failures can leave
node_modules/electronhalf-installed, and the break onlysurfaces later when
npm run devfails withElectron failed to install correctly.Our desktop/frontend workflows already run on Node 20, so this is local-dev
friction caused by missing guardrails rather than an app-specific code path.
Change
engines.node = 20.xtofrontend/package.jsonpreinstallcheck that fails fast on unsupported Node versions withclear remediation steps
frontend/.nvmrcTest
Result:
Unsupported-node guard:
Verified:
corrupt
node_modulesNotes
npm run typecheckstill reports the pre-existingforge.config.tstypingerror around
osxNotarize; this change does not modify that area.