Updates to make use of aodncore API improvements#249
Draft
Conversation
Add fail-fast: false
for remote file downloads and file_collection additions
to remove type warnings in PyCharm
mhidas
force-pushed
the
update_for_new_aodncore_api
branch
from
c0449e1 to
bc7b709
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 88.02% 87.98% -0.05%
==========================================
Files 50 50
Lines 3214 3203 -11
Branches 534 534
==========================================
- Hits 2829 2818 -11
Misses 241 241
Partials 144 144
Continue to review full report at Codecov.
|
mhidas
commented
Jan 21, 2021
Comment on lines
+82
to
84
| files_for_layer = broker.query_files('soop_trv_duplicate_url') | ||
| self.assertEqual(files_for_layer[0], | ||
| 'IMOS/SOOP/SOOP-TRV/VMQ9273_Solander/By_Cruise/Cruise_START-20181205T035932Z_END-20181206T045722Z/temperature/IMOS_SOOP-TRV_T_20181205T035932Z_VMQ9273_FV01_END-20181206T045722Z.nc') |
Contributor
Author
There was a problem hiding this comment.
@lwgordonimos Should this test be creating a WfsBroker instead of using the new state_query api?
e.g.
Suggested change
| files_for_layer = broker.query_files('soop_trv_duplicate_url') | |
| self.assertEqual(files_for_layer[0], | |
| 'IMOS/SOOP/SOOP-TRV/VMQ9273_Solander/By_Cruise/Cruise_START-20181205T035932Z_END-20181206T045722Z/temperature/IMOS_SOOP-TRV_T_20181205T035932Z_VMQ9273_FV01_END-20181206T045722Z.nc') | |
| handler = self.handler_class(GOOD_NC) | |
| files_for_layer = handler.state_query.query_wfs_files('soop_trv_duplicate_url') | |
| self.assertEqual(files_for_layer[0].dest_path, | |
| 'IMOS/SOOP/SOOP-TRV/VMQ9273_Solander/By_Cruise/Cruise_START-20181205T035932Z_END-20181206T045722Z/temperature/IMOS_SOOP-TRV_T_20181205T035932Z_VMQ9273_FV01_END-20181206T045722Z.nc') |
In fact, this is already implicitly tested by test_good_netcdf above, so this one is kind of rendundant.
@lbesnard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aodn/python-aodncore#209 introduces a couple of API improvements for:
PipelineFileobjects to theirfile_collection; andThe old functionality is still there, but now issues deprecation warnings.
This PR is to update all handlers to use the new API, so the old methods can be removed in a future aodncore update.