Conversation
lbesnard
approved these changes
Jul 22, 2025
Contributor
|
Since this only touches the github action code it won't break legacy pipelines. Any changes to fix dependencies outside of github actions (eg stage-requirements.txt) though could break legacy, so I think the best policy is to not touch the stuff outside actions until we're either forced to do so by something breaking or we've decommissioned the legacy pipelines |
akashisama
approved these changes
Aug 1, 2025
Contributor
Author
Contributor
|
[celebrate] Benedicte Pasquer reacted to your message:
…________________________________
From: Michael Hemming ***@***.***>
Sent: Tuesday, August 5, 2025 12:44:58 AM
To: aodn/python-aodndata ***@***.***>
Cc: Benedicte Pasquer ***@***.***>; Mention ***@***.***>
Subject: Re: [aodn/python-aodndata] Fix dependencies issue (PR #405)
[https://avatars.githubusercontent.com/u/18735092?s=20&v=4]mphemming left a comment (aodn/python-aodndata#405)<#405 (comment)>
@bpasquer<https://github.com/bpasquer> @vfisaac<https://github.com/vfisaac> this PR has now been merged
—
Reply to this email directly, view it on GitHub<#405 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA4PQ3ALI2OTMFQFUF4PVN33L75AVAVCNFSM6AAAAAB7L46Y4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJSHA4TSOBTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
This email is confidential, and is for the intended recipient only. Access, disclosure, copying, distribution, or reliance on any of it by anyone outside the intended recipient organisation is prohibited and may be a criminal offence. Please delete if obtained in error and email confirmation to the sender. The views expressed in this email are not necessarily the views of the University of Tasmania, unless clearly intended otherwise.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit of a mess to clean up but it is now working. It is only a band-aid solution for GH Actions. I don't have much knowledge about how
python-adondataworks to get stuck into exploring and testing the repo. And I haven't touched the requirements for the repository, hence there is now quite a difference between the packages inside the container used for the GH Actions and the packages used for the repository (see below).Initial error
× Getting requirements to build wheel did not run successfully.(see full error here)This error occured when trying to install
shapely==2.0.7by default, and not findingnp.intp_tin the version of Numpy that was available, hence the build crashes.Solution
numpy<1.24.0-> containsnp.intp_t,pandas<2.0to avoid any breaking changes, andmatplotlib>=3.1,<3.6that works well withCartopy 0.20.3(another requirement).cartopyandshapelyhave access to their C libraries (GEOS, PROJ, GDAL/OGR, UDUNITS2). These libraries are installed and available in the container.shapely(1.8.5.post1) that will work withnumpy<1.24.0and the C libraries.cartopy=0.20.31from source (as not available as a wheel), linking to C libraries.Questions
Different environments
FYI @bpasquer @vfisaac