Skip to content

[WIP] MP unit tests crash fix#49

Open
mykola-kobets-epam wants to merge 5 commits intoaosedge:developfrom
mykola-kobets-epam:mp-unit-tests-crash-fix
Open

[WIP] MP unit tests crash fix#49
mykola-kobets-epam wants to merge 5 commits intoaosedge:developfrom
mykola-kobets-epam:mp-unit-tests-crash-fix

Conversation

@mykola-kobets-epam
Copy link
Collaborator

No description provided.

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
pkcs11-provider crashes on simultaneous load priv key.

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
@mykola-kobets-epam mykola-kobets-epam changed the title MP unit tests crash fix [WIP] MP unit tests crash fix Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@09832d7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/mp/communication/securechannel.cpp 75.86% 7 Missing ⚠️
src/mp/communication/tests/stubs/transport.hpp 69.23% 4 Missing ⚠️
src/mp/communication/tests/communicationsecure.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #49   +/-   ##
==========================================
  Coverage           ?   79.98%           
==========================================
  Files              ?      222           
  Lines              ?    23933           
  Branches           ?     2207           
==========================================
  Hits               ?    19144           
  Misses             ?     4789           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
52.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>

/***********************************************************************************************************************
* Statics
**********************************************************************************************************************/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line after comment header

SSL* mSSL {};
std::unique_ptr<BIO_METHOD, decltype(&BIO_meth_free)> mBioMethod {nullptr, BIO_meth_free};
std::atomic<bool> mConnected {};
std::recursive_mutex mReadMutex;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess one normal mutex should be enough. No?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments