fix: Use Playwright Docker image for CI to resolve dependency issues#69
Merged
Conversation
- Switch to official Playwright Docker image (mcr.microsoft.com/playwright:v1.48.0-noble) - Remove manual browser installation steps as they're pre-installed in the image - Set PLAYWRIGHT_BROWSERS_PATH environment variable to use pre-installed browsers - Keep Playwright CLI installation for Go integration This resolves all missing system dependencies that were preventing Playwright tests from running in CI. Fixes #68
- Install gcc, g++, and libc6-dev for CGO support - Set CGO_ENABLED=1 for race detection - Required for running tests with -race flag in Docker container
Allow running as root user to install system packages with apt-get
Fix 'dubious ownership' error by adding the workspace directory to git's safe.directory list
Owner
Author
✅ CI成功!すべてのCIチェックが成功しました。Playwright Dockerイメージを使用することで、依存関係の問題が解決されました。 実装内容
結果
これでPhase 2が完了し、CI環境でPlaywrightテストを実行できるようになりました。次はPR #67に戻ってPhase 3を完了できます。 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the incomplete implementation of Phase 2 (#63) by using the official Playwright Docker image in CI, which includes all required system dependencies.
Problem
The CI environment (Ubuntu 24.04) was missing critical system dependencies for Playwright:
The
playwright install --with-deps chromiumcommand was insufficient due to package naming changes in Ubuntu 24.04 (many packages now have at64suffix).Solution
Use the official Playwright Docker image (
mcr.microsoft.com/playwright:v1.48.0-noble) which:Changes Made
PLAYWRIGHT_BROWSERS_PATHenvironment variableTesting
This PR will validate that:
Related Issues
🤖 Generated with Claude Code