prevent deleteRows of system tables#5491
Conversation
|
I can see why we wouldn't want users to delete from the fate table. It's managed by the Manager, which is supposed to always be running. However, I'm wondering if we want to allow delete rows on the |
|
|
keith-turner
left a comment
There was a problem hiding this comment.
#5747 will eventually completely test these changes? Seems like thats the case, just wanted to make sure.
|
@keith-turner - Did you mean #5474? If so, yes that PR will test these changes |
Prevents
tableOperations().deleteRowsof system tables in 4.0.2.1 system tables:
cannotdelete rowscannotdelete rowscandeleteRows4.0 system tables:
cannotdelete rows, after: samecannotdelete rows, after: samecandelete rows, after:cannotdelete rowscandelete rows, after:cannotdelete rowsI did not target 2.1 because I was unsure if we want
deleteRowsfor the replication table (seems like that was the intent, but table expectations changed in 4.0).Created from discussion: #5474 (comment)