Skip to content

Added correct thread naming to compactor threads #6144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddanielr merged 2 commits into from
Feb 24, 2026
+12 −5
Merged

Added correct thread naming to compactor threads #6144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
961bdf8
Added correct thread naming to compactor threads
ddanielr Feb 23, 2026
c09df33
Reduce changes by not supporting ExtC
ddanielr Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,19 @@ public CompactionStats call() throws IOException, CompactionCanceledException,

clearCurrentEntryCounts();

final boolean isMinC = env.getIteratorScope() == IteratorUtil.IteratorScope.minc;

StringBuilder newThreadName = new StringBuilder();
if (isMinC) {
newThreadName.append("MinC ");
} else {
newThreadName.append("MajC ");
}

String oldThreadName = Thread.currentThread().getName();
String newThreadName =
"MajC compacting " + extent + " started " + threadStartDate + " file: " + outputFile;
Thread.currentThread().setName(newThreadName);
newThreadName.append("compacting ").append(extent).append(" started ").append(threadStartDate)
.append(" file: ").append(outputFile);
Thread.currentThread().setName(newThreadName.toString());
// Use try w/ resources for clearing the thread instead of finally because clearing may throw an
// exception. Java's handling of exceptions thrown in finally blocks is not good.
try (var ignored = setThread()) {
Expand All @@ -348,8 +357,6 @@ public CompactionStats call() throws IOException, CompactionCanceledException,
final EnumSet<FilePrefix> dropCacheFileTypes =
ConfigurationTypeHelper.getDropCacheBehindFilePrefixes(dropCachePrefixProperty);

final boolean isMinC = env.getIteratorScope() == IteratorUtil.IteratorScope.minc;

final boolean dropCacheBehindOutput = !RootTable.ID.equals(this.extent.tableId())
&& !MetadataTable.ID.equals(this.extent.tableId())
&& ((isMinC && acuTableConf.getBoolean(Property.TABLE_MINC_OUTPUT_DROP_CACHE))
Expand Down