Skip to content

Wrap fate thrift service with highly available service #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keith-turner wants to merge 2 commits into
base: 2.1
Choose a base branch
from
+9 −12
Open

Wrap fate thrift service with highly available service #6152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0f3b6
Wrap fate thrift service with highly available service
keith-turner Feb 24, 2026
7065720
fixes bug
keith-turner Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
import org.apache.accumulo.core.manager.balancer.TServerStatusImpl;
import org.apache.accumulo.core.manager.balancer.TabletServerIdImpl;
import org.apache.accumulo.core.manager.state.tables.TableState;
import org.apache.accumulo.core.manager.thrift.FateService;
import org.apache.accumulo.core.manager.thrift.ManagerClientService;
import org.apache.accumulo.core.manager.thrift.ManagerGoalState;
import org.apache.accumulo.core.manager.thrift.ManagerMonitorInfo;
Expand Down Expand Up @@ -326,9 +327,6 @@ synchronized void setManagerState(final ManagerState newState) {

private Future<Void> upgradeMetadataFuture;

private FateServiceHandler fateServiceHandler;
private ManagerClientServiceHandler managerClientHandler;

private int assignedOrHosted(TableId tableId) {
int result = 0;
for (TabletGroupWatcher watcher : watchers) {
Expand Down Expand Up @@ -1239,17 +1237,16 @@ public void run() {
// ACCUMULO-4424 Put up the Thrift servers before getting the lock as a sign of process health
// when a hot-standby
//
// Start the Manager's Fate Service
fateServiceHandler = new FateServiceHandler(this);
managerClientHandler = new ManagerClientServiceHandler(this);
// Start the Manager's Client service
// Ensure that calls before the manager gets the lock fail
ManagerClientService.Iface haProxy =
HighlyAvailableServiceWrapper.service(managerClientHandler, this);
// Start the Manager's Fate Service. Ensure that calls before the manager gets the lock fail
FateService.Iface fateServiceHandler =
HighlyAvailableServiceWrapper.service(new FateServiceHandler(this), this);
// Start the Manager's Client service. Ensure that calls before the manager gets the lock fail
ManagerClientService.Iface managerClientHandler =
HighlyAvailableServiceWrapper.service(new ManagerClientServiceHandler(this), this);

ServerAddress sa;
var processor =
ThriftProcessorTypes.getManagerTProcessor(this, fateServiceHandler, haProxy, getContext());
var processor = ThriftProcessorTypes.getManagerTProcessor(this, fateServiceHandler,
managerClientHandler, getContext());

try {
@SuppressWarnings("deprecation")
Expand Down