Open
Conversation
DImuthuUpe
requested changes
Aug 22, 2023
Contributor
DImuthuUpe
left a comment
DImuthuUpe
left a comment
There was a problem hiding this comment.
Hi @nandarshan this is a great start and thanks for working on this feature. Please refer to this PR in this issue #107 mentioning that you are working on it.
Regarding the code, remove all standard.out.println and e.printStacktrace as those are not logger friendly. Use a logger function instead. Once you have fixed those, I will do in-depth review of the code
Contributor
Author
|
Thanks for the reply @DImuthuUpe. I have removed all println and printStackTrace statements and added logger functions instead. Please let me know if there are any other corrections required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, to store secrets, Vault from Hashicorp is being used. This PR implements the getSCPSecret, createSCPSecret, updateSCPSecret, and deleteSCPSecret methods for the SCP in VaultSecretBackend.java. This PR also contains the scripts to start and stop the vault.
Issue: #107