Open
Conversation
Contributor
|
@harshittiwariii Thanks for the PR. Deleting grpc dependencies from the inventory will cause the missing dependency issue for fresh installations. The issue here is the grpc 1.43.1 is not compatible with python 11. I have provided a fix which install grpc on a conditional basis for different Python versions 72ecfd9. You can try the binary with latest mft distribution using |
Author
|
@DImuthuUpe Thank you for the information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #104 and #106 and #122
Fixes: #104 and #122
Motivation
Specific versions of grpcio and grpcio-tools were reverting back to previous versions while installing airavata-mft with Python3.11
Modifications
grpcio= [{version="1.46.3", markers = "platform_machine != 'arm64'"},{version="1.47.0rc1", markers = "platform_machine == 'arm64'"}]
grpcio-tools = [{version="1.46.3", markers = "platform_machine != 'arm64'"},{version="1.47.0rc1", markers = "platform_machine == 'arm64'"}]
Both grpcio and grpcio-tools are removed now.
Documentation
If a feature is not applicable for documentation, explain why?
This is not applicable for documentation because the core functionality remains same.