Skip to content

AMBARI-26142: Upgrade to JDK 17 compatibility with dependency updates…#64

Open
almeidajeff wants to merge 1 commit into
apache:masterfrom
almeidajeff:AMBARI-26142-support-jdk17-for-ambari-infra-solr
Open

AMBARI-26142: Upgrade to JDK 17 compatibility with dependency updates…#64
almeidajeff wants to merge 1 commit into
apache:masterfrom
almeidajeff:AMBARI-26142-support-jdk17-for-ambari-infra-solr

Conversation

@almeidajeff

@almeidajeff almeidajeff commented May 26, 2026

Copy link
Copy Markdown

… and test coverage

  • Upgrade maven-failsafe-plugin from 3.0.0-M1 to 3.2.5
  • Upgrade cglib from 3.2.4 to 3.3.0 for JDK 17 bytecode compatibility
  • Upgrade guava from 28.0-jre to 32.1.3-jre for JDK 17 support
  • Add comprehensive JDK17CompatibilityTest covering reflection, JAXB, CGLib, Guava, and --add-opens validation
  • Add unit tests for EnvironmentalSecret, SchedulingProperties, CompositeFileAction, and MetricsUtils

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

AMBARI-26142: Upgrade to JDK 17 compatibility with dependency updates…
1bc73b7 
… and test coverage

- Upgrade maven-failsafe-plugin from 3.0.0-M1 to 3.2.5
- Upgrade cglib from 3.2.4 to 3.3.0 for JDK 17 bytecode compatibility
- Upgrade guava from 28.0-jre to 32.1.3-jre for JDK 17 support
- Add comprehensive JDK17CompatibilityTest covering reflection, JAXB, CGLib, Guava, and --add-opens validation
- Add unit tests for EnvironmentalSecret, SchedulingProperties, CompositeFileAction, and MetricsUtils
@almeidajeff

almeidajeff commented May 27, 2026

Copy link
Copy Markdown
Author

Environment

Here is some important information about the test

  • Operating System: Rocky 9
  • JAVA_HOME=/usr/lib/jvm/java-17-openjdk

Command executed for testing:

mvn -B clean test -Drat.skip=true \
    -pl ambari-infra-solr-client,ambari-infra-solr-plugin,ambari-infra-manager \
    -am \
    -Dmaven.wagon.http.ssl.insecure=true \
    -Dmaven.wagon.http.ssl.allowall=true

Test output

[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.176 s -- in org.apache.ambari.infra.solr.AmbariSolrCloudClientTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- apache-rat:0.12:check (default) @ ambari-infra-solr-client ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO] 
[INFO] -------------< org.apache.ambari:ambari-infra-solr-plugin >-------------
[INFO] Building Ambari Infra Solr Plugin 3.0.0.0-SNAPSHOT                 [3/4]
[INFO]   from ambari-infra-solr-plugin/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- clean:2.5:clean (default-clean) @ ambari-infra-solr-plugin ---
[INFO] Deleting /build/ambari-infra/ambari-infra-solr-plugin/target
[INFO] Deleting /build/ambari-infra/ambari-infra-solr-plugin (includes = [**/*.pyc], excludes = [])
[INFO] 
[INFO] --- flatten:1.0.0:clean (flatten.clean) @ ambari-infra-solr-plugin ---
[INFO] Deleting /build/ambari-infra/ambari-infra-solr-plugin/.flattened-pom.xml
[INFO] 
[INFO] --- build-helper:1.8:parse-version (parse-version) @ ambari-infra-solr-plugin ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (regex-property) @ ambari-infra-solr-plugin ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (parse-package-version) @ ambari-infra-solr-plugin ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (parse-package-release) @ ambari-infra-solr-plugin ---
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ ambari-infra-solr-plugin ---
[INFO] Copying 1 resource from src/main/resources to target/classes
[INFO] 
[INFO] --- flatten:1.0.0:flatten (flatten) @ ambari-infra-solr-plugin ---
[INFO] Generating flattened POM of project org.apache.ambari:ambari-infra-solr-plugin:jar:3.0.0.0-SNAPSHOT...
[INFO] 
[INFO] --- compiler:3.5:compile (default-compile) @ ambari-infra-solr-plugin ---
[INFO] Compiling 13 source files to /build/ambari-infra/ambari-infra-solr-plugin/target/classes
[INFO] /build/ambari-infra/ambari-infra-solr-plugin/src/main/java/org/apache/ambari/infra/solr/metrics/reporters/ScheduledAMSReporter.java: Some input files use unchecked or unsafe operations.
[INFO] /build/ambari-infra/ambari-infra-solr-plugin/src/main/java/org/apache/ambari/infra/solr/metrics/reporters/ScheduledAMSReporter.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ ambari-infra-solr-plugin ---
[INFO] skip non existing resourceDirectory /build/ambari-infra/ambari-infra-solr-plugin/src/test/resources
[INFO] 
[INFO] --- compiler:3.5:testCompile (default-testCompile) @ ambari-infra-solr-plugin ---
[INFO] Compiling 5 source files to /build/ambari-infra/ambari-infra-solr-plugin/target/test-classes
[INFO] /build/ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/solr/security/InfraRuleBasedAuthorizationPluginTest.java: /build/ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/solr/security/InfraRuleBasedAuthorizationPluginTest.java uses unchecked or unsafe operations.
[INFO] /build/ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/solr/security/InfraRuleBasedAuthorizationPluginTest.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- surefire:3.2.5:test (default-test) @ ambari-infra-solr-plugin ---
[INFO] Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.ambari.infra.solr.metrics.reporters.MetricsUtilsTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.600 s -- in org.apache.ambari.infra.solr.metrics.reporters.MetricsUtilsTest
[INFO] Running org.apache.solr.security.InfraKerberosHostValidatorTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s -- in org.apache.solr.security.InfraKerberosHostValidatorTest
[INFO] Running org.apache.solr.security.InfraUserRolesLookupStrategyTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 s -- in org.apache.solr.security.InfraUserRolesLookupStrategyTest
[INFO] Running org.apache.solr.security.InfraRuleBasedAuthorizationPluginTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 s -- in org.apache.solr.security.InfraRuleBasedAuthorizationPluginTest
[INFO] Running org.apache.solr.security.JDK17SolrPluginCompatibilityTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 s -- in org.apache.solr.security.JDK17SolrPluginCompatibilityTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- apache-rat:0.12:check (default) @ ambari-infra-solr-plugin ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO] 
[INFO] ---------------< org.apache.ambari:ambari-infra-manager >---------------
[INFO] Building Ambari Infra Manager 3.0.0.0-SNAPSHOT                     [4/4]
[INFO]   from ambari-infra-manager/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- clean:2.5:clean (default-clean) @ ambari-infra-manager ---
[INFO] Deleting /build/ambari-infra/ambari-infra-manager/target
[INFO] Deleting /build/ambari-infra/ambari-infra-manager (includes = [**/*.pyc], excludes = [])
[INFO] 
[INFO] --- flatten:1.0.0:clean (flatten.clean) @ ambari-infra-manager ---
[INFO] Deleting /build/ambari-infra/ambari-infra-manager/.flattened-pom.xml
[INFO] 
[INFO] --- build-helper:1.8:parse-version (parse-version) @ ambari-infra-manager ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (regex-property) @ ambari-infra-manager ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (parse-package-version) @ ambari-infra-manager ---
[INFO] 
[INFO] --- build-helper:1.8:regex-property (parse-package-release) @ ambari-infra-manager ---
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ ambari-infra-manager ---
[INFO] Copying 9 resources from src/main/resources to target/classes
[INFO] 
[INFO] --- flatten:1.0.0:flatten (flatten) @ ambari-infra-manager ---
[INFO] Generating flattened POM of project org.apache.ambari:ambari-infra-manager:jar:3.0.0.0-SNAPSHOT...
[INFO] 
[INFO] --- compiler:3.5:compile (default-compile) @ ambari-infra-manager ---
[INFO] Compiling 100 source files to /build/ambari-infra/ambari-infra-manager/target/classes
[INFO] /build/ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java: /build/ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java uses or overrides a deprecated API.
[INFO] /build/ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java: Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] --- swagger:3.1.7:generate (default) @ ambari-infra-manager ---
[INFO] Reflections took 55 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 4 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 3 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 3 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 4 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 4 ms to scan 1 urls, producing 6 keys and 7 values 
[INFO] Reflections took 405 ms to scan 5 urls, producing 794 keys and 4375 values 
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ ambari-infra-manager ---
[INFO] skip non existing resourceDirectory /build/ambari-infra/ambari-infra-manager/src/test/resources
[INFO] 
[INFO] --- compiler:3.5:testCompile (default-testCompile) @ ambari-infra-manager ---
[INFO] Compiling 19 source files to /build/ambari-infra/ambari-infra-manager/target/test-classes
[INFO] /build/ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/JobSchedulerTest.java: /build/ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/JobSchedulerTest.java uses unchecked or unsafe operations.
[INFO] /build/ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/JobSchedulerTest.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- surefire:3.2.5:test (default-test) @ ambari-infra-manager ---
[INFO] Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.ambari.infra.job.JobSchedulerTest
18:46:10.133 [main] INFO  org.apache.ambari.infra.job.JobScheduler:62 - Job job0 scheduled for running. Cron: * * * * * ?
18:46:10.148 [main] INFO  org.apache.ambari.infra.job.JobScheduler:62 - Job job0 scheduled for running. Cron: * * * * * ?
18:46:10.153 [main] INFO  org.apache.ambari.infra.job.JobScheduler:62 - Job job0 scheduled for running. Cron: * * * * * ?
18:46:10.158 [main] INFO  org.apache.ambari.infra.job.JobScheduler:62 - Job job0 scheduled for running. Cron: * * * * * ?
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.018 s -- in org.apache.ambari.infra.job.JobSchedulerTest
[INFO] Running org.apache.ambari.infra.job.SchedulingPropertiesTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 s -- in org.apache.ambari.infra.job.SchedulingPropertiesTest
[INFO] Running org.apache.ambari.infra.job.archive.SolrQueryPropertiesTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s -- in org.apache.ambari.infra.job.archive.SolrQueryPropertiesTest
[INFO] Running org.apache.ambari.infra.job.archive.FileNameSuffixFormatterTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 s -- in org.apache.ambari.infra.job.archive.FileNameSuffixFormatterTest
[INFO] Running org.apache.ambari.infra.job.archive.DocumentExporterTest
18:46:10.285 [main] INFO  org.apache.ambari.infra.job.archive.DocumentExporter:81 - Received stop signal.
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.042 s -- in org.apache.ambari.infra.job.archive.DocumentExporterTest
[INFO] Running org.apache.ambari.infra.job.archive.CompositeFileActionTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 s -- in org.apache.ambari.infra.job.archive.CompositeFileActionTest
[INFO] Running org.apache.ambari.infra.job.archive.DocumentItemReaderTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 s -- in org.apache.ambari.infra.job.archive.DocumentItemReaderTest
[INFO] Running org.apache.ambari.infra.job.archive.SolrParametrizedStringTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s -- in org.apache.ambari.infra.job.archive.SolrParametrizedStringTest
[INFO] Running org.apache.ambari.infra.job.archive.LocalDocumentItemWriterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.366 s -- in org.apache.ambari.infra.job.archive.LocalDocumentItemWriterTest
[INFO] Running org.apache.ambari.infra.job.archive.DocumentTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 s -- in org.apache.ambari.infra.job.archive.DocumentTest
[INFO] Running org.apache.ambari.infra.job.archive.SolrQueryBuilderTest
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.088 s -- in org.apache.ambari.infra.job.archive.SolrQueryBuilderTest
[INFO] Running org.apache.ambari.infra.job.archive.SolrPropertiesTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in org.apache.ambari.infra.job.archive.SolrPropertiesTest
[INFO] Running org.apache.ambari.infra.conf.security.CompositeSecretTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s -- in org.apache.ambari.infra.conf.security.CompositeSecretTest
[INFO] Running org.apache.ambari.infra.conf.security.EnvironmentalSecretTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in org.apache.ambari.infra.conf.security.EnvironmentalSecretTest
[INFO] Running org.apache.ambari.infra.json.FsPermissionToStringConverterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/root/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.10.0/log4j-slf4j-impl-2.10.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/root/.m2/repository/org/slf4j/slf4j-reload4j/1.7.36/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 s -- in org.apache.ambari.infra.json.FsPermissionToStringConverterTest
[INFO] Running org.apache.ambari.infra.JDK17CompatibilityTest
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.388 s -- in org.apache.ambari.infra.JDK17CompatibilityTest
[INFO] Running org.apache.ambari.infra.model.ISO8601DateFormatterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in org.apache.ambari.infra.model.ISO8601DateFormatterTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 89, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- apache-rat:0.12:check (default) @ ambari-infra-manager ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for ambari-infra 3.0.0.0-SNAPSHOT:
[INFO] 
[INFO] ambari-infra ....................................... SUCCESS [  1.305 s]
[INFO] Ambari Infra Solr Client ........................... SUCCESS [  4.732 s]
[INFO] Ambari Infra Solr Plugin ........................... SUCCESS [  2.923 s]
[INFO] Ambari Infra Manager ............................... SUCCESS [  9.921 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19.061 s
[INFO] Finished at: 2026-05-27T18:46:11Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@almeidajeff