Skip to content

Fix IndexOutOfBoundsException when calling PostRequest.getUpstreamHeaders #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MariaLapovska wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix IndexOutOfBoundsException when calling PostRequest.getUpstreamHeaders #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/RpcCallHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ private void handleHttpRespCall(ChannelHandlerContext ctx, PostRequest request)

PluginFilterChain chain = conf.getChain();

// here we pre-read parameters in the resp to
// prevent confusion over the read/write index of the resp.
preReadPostReq();

if (Objects.isNull(chain) || 0 == chain.getFilters().size()) {
ChannelFuture future = ctx.writeAndFlush(postResp);
future.addListeners(ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE);
Expand Down Expand Up @@ -328,6 +332,11 @@ private void preReadReq() {
currReq.getSourceIP();
}

private void preReadPostReq() {
postReq.getUpstreamHeaders();
postReq.getUpstreamStatusCode();
}

private void errorHandle(ChannelHandlerContext ctx, int code) {
A6ErrResponse errResponse = new A6ErrResponse(code);
ctx.writeAndFlush(errResponse);
Expand Down