Skip to content

chore: Fix PR comment message grammar#99

Merged
kou merged 3 commits into
apache:mainfrom
Benjamin-Philip:bp/fix-pr-comment-grammar
Jul 8, 2026
Merged

chore: Fix PR comment message grammar#99
kou merged 3 commits into
apache:mainfrom
Benjamin-Philip:bp/fix-pr-comment-grammar

Conversation

@Benjamin-Philip

@Benjamin-Philip Benjamin-Philip commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What issue does this PR fix?

The PR comment message had a few grammatical errors. This PR fixes them.

@Benjamin-Philip
Benjamin-Philip requested review from Copilot and kou and removed request for Copilot July 8, 2026 09:47
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Preview URL: https://Benjamin-Philip.github.io/arrow-erlang-1

If the preview URL doesn't work, you may forget to configure your fork repository for preview.
See https://github.com/apache/arrow-erlang/blob/main/CONTRIBUTING.md#forks how to configure.

@kou
kou requested a review from Copilot July 8, 2026 13:38
Copilot AI reviewed Jul 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow that posts a PR comment, intending to fix grammar in the generated preview-instructions message.

Changes:

  • Updated the preview help text emitted into body.md for the PR comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr_comment.yml Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 13:50
Copilot AI reviewed Jul 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/pr_comment.yml Outdated
@Benjamin-Philip

Benjamin-Philip commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Ironic (dumb?) mistake for a grammar fix. I should run spellcheckers on prog-mode buffers as well.

@Benjamin-Philip
Clarify instructions
ffa1fab 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 13:53
Copilot AI reviewed Jul 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

kou
kou approved these changes Jul 8, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 1447e34 into apache:main Jul 8, 2026
11 checks passed
@Benjamin-Philip
Benjamin-Philip deleted the bp/fix-pr-comment-grammar branch July 8, 2026 13:55
@Benjamin-Philip

Benjamin-Philip commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

It might be worth updating your message in the other repos where you use this workflow.

@kou

kou commented Jul 8, 2026

Copy link
Copy Markdown
Member

It makes sense. Could you open PRs for them?

@Benjamin-Philip Benjamin-Philip mentioned this pull request Jul 9, 2026
Merged
kou pushed a commit to apache/arrow-site that referenced this pull request Jul 9, 2026
@Benjamin-Philip
chore: Fix grammar in PR preview comment (#787)
37db992 
## What's Changed

This PR fixes some minor grammatical issues in the PR preview message.
This was first caught in apache/arrow-erlang#99 when we were setting up
previews based on the flow in this repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Benjamin-Philip @kou