fix(compute/kernels): map FSB byte-width to numeric memo type for is_in#797
Merged
zeroshade merged 1 commit intoapache:mainfrom May 4, 2026
Merged
Conversation
CreateSetLookupState routes FixedSizeBinary widths 1/2/4/8 onto the numeric fast path (SetLookupState[uintN] + visitNumeric[uintN]), but Init asked newMemoTable for arrow.FIXED_SIZE_BINARY and got a BinaryMemoTable, which fails the TypedMemoTable[uintN] assertion. Map the byte-width to the matching uint type before the lookup, and only release in CleanupFn when the state actually carries a BinaryMemoTable so the numeric paths don't fall over a wrong type assertion either. Adds a regression test exercising widths 1/2/4/8. Signed-off-by: SAY-5 <say.apm35@gmail.com>
zeroshade
approved these changes
May 4, 2026
Member
|
Thanks for this! Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #785.
CreateSetLookupStatealready routesFixedSizeBinarywidths 1/2/4/8 onto the numeric fast path (SetLookupState[uintN]+visitNumeric[uintN]), butInitthen askednewMemoTableforarrow.FIXED_SIZE_BINARYand got aBinaryMemoTable, which fails the subsequentTypedMemoTable[uintN]assertion. The cleanup hook had the same blind spot — it cast every state toSetLookupState[[]byte]and would have panicked there too once Init was fixed.Map the FSB byte-width to the matching uint type before the lookup, and only release in
CleanupFnwhen the state actually carries aBinaryMemoTable. Adds a regression test exercising widths 1/2/4/8.