GH-1205: Fix byte-array element leak in FromSchemaByteArray#1249
Open
PG1204 wants to merge 1 commit into
Open
Conversation
…releasing elements via RAII guard
PG1204
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
July 24, 2026 17:32
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
FromSchemaByteArray()indataset/src/main/cpp/jni_util.ccacquires the Java byte-array elements viaGetByteArrayElements(), but the matchingReleaseByteArrayElements()call was only reached on the success path.When
arrow::ipc::ReadSchema()failed,ARROW_ASSIGN_OR_RAISEreturned early and skipped the release, leaking the pinned/copied array buffer on every call with malformed or incompatible serialized schema bytes (e.g. via the publiccreateDataset()method).This change releases the elements through an RAII guard (a
std::unique_ptrwith a custom deleter) so they are always freed on every exit path - success or error, and remains correct if additional early returns areadded in the future.
Closes #1205.