Stricter datatype parsing for decimals, fixedsizelists and time32/64#10147
Open
Jefffrey wants to merge 3 commits into
Open
Stricter datatype parsing for decimals, fixedsizelists and time32/64#10147Jefffrey wants to merge 3 commits into
Jefffrey wants to merge 3 commits into
Conversation
thepenguinco
approved these changes
Jun 19, 2026
thepenguinco
left a comment
thepenguinco
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable, maybe few unit test additions would be good to prevent regression?
Contributor
Author
do you mean adding further tests? since this PR does add such unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Uphold invariants when parsing datatypes from string.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.