nit: pyarrow: simplify class validation error creation#10154
Open
Tpt wants to merge 1 commit into
Open
Conversation
`fully_qualified_name` returns the fully qualified name of the type like `pyarrow.Table`
Tpt
force-pushed
the
tpt/python-accessors
branch
from
ab009ed to
ce704f6
Compare
alamb
approved these changes
Jun 18, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
looks like a nice change to me -- thank you @Tpt
cc @timsaucer and @kylebarron
kylebarron
approved these changes
Jun 18, 2026
kylebarron
left a comment
kylebarron
left a comment
Member
There was a problem hiding this comment.
Nice, it uses an actual C API method PyType_GetFullyQualifiedName()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fully_qualified_namereturns the fully qualified name of the type likepyarrow.Table. Hence, there should not be any visible change