feat(pyarrow) FromPyArrow on Vec<T>: allow any iterable for input#10155
Open
Tpt wants to merge 2 commits into
Open
feat(pyarrow) FromPyArrow on Vec<T>: allow any iterable for input#10155Tpt wants to merge 2 commits into
FromPyArrow on Vec<T>: allow any iterable for input#10155Tpt wants to merge 2 commits into
Conversation
This is already the behavior of `FromPyObject` implementation on `Vec<T: FromPyObject>`
Tpt
force-pushed
the
tpt/from-py-arrow-vec
branch
from
e02a7ae to
66cff0b
Compare
alamb
reviewed
Jun 18, 2026
| fn from_pyarrow_bound(value: &Bound<PyAny>) -> PyResult<Self> { | ||
| let list = value.cast::<PyList>()?; | ||
| list.iter().map(|x| T::from_pyarrow_bound(&x)).collect() | ||
| let mut v = Vec::with_capacity(value.len().unwrap_or(0)); |
Contributor
There was a problem hiding this comment.
Why not keep the collect syntax?
Contributor
Author
There was a problem hiding this comment.
This is a micro-opt to pre-allocate the Vec at the expected size. .collect() won't have a visibility on it because of PyAny::try_iter. Glad to revert if you prefer
alamb
approved these changes
Jun 18, 2026
Tpt
force-pushed
the
tpt/from-py-arrow-vec
branch
from
77a5996 to
a212868
Compare
Contributor
Author
|
Thank you!
Done: a212868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already the behavior of
FromPyObjectimplementation onVec<T: FromPyObject>