[Variant] Fix the variant shred logic#10157
Open
klion26 wants to merge 1 commit into
Open
Conversation
klion26
force-pushed
the
fix_variant_shred
branch
from
32a3f09 to
aca457f
Compare
Previously, variant_shred and variant_get reuse the same code path, causing type mismatches (e.g., bool was incorrectly shredded as int). This commit separates the shred path and ensures each type is converted correctly.
klion26
force-pushed
the
fix_variant_shred
branch
from
aca457f to
003214c
Compare
klion26
commented
Jun 18, 2026
| impl_primitive_from_variant!(datatypes::Float32Type, as_f32); | ||
| impl_primitive_from_variant!(datatypes::Float64Type, as_f64); | ||
| impl_primitive_from_variant!(datatypes::Date32Type, as_naive_date, |v| { | ||
| enum NumericKind { |
Member
Author
There was a problem hiding this comment.
These code are mainly moved from Variant.rs, the change here was adding the parameter shred for from_variant and variant_to_unscaled_decimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
variant_shredandvariant_getby introduceshredflag for row builderVariant::as_xxxtotype_conversion, and these moved code will be used whenvariant_get,variant_shredwill useVariant::as_xxxint8can be treated asint8/int16/int32/int64, butbool/.../floatcan't be treated asint*,floatcan be shredded intofloat/double, butintcan't be shredded tofloat/double,decimal4can be shredded intodecimal32/64/128(_, _), butint/floatcan't be shredded intodecimaltest_variant_type_shredded_correctlyAre these changes tested?
Yes, added some tests to cover the logic
Are there any user-facing changes?
Yes, some
Variant::as_xxlogic have been changed.