Skip to content

Fix Variant time microsecond JSON formatting #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefffrey merged 1 commit into from
Jun 22, 2026
+16 −1
Merged

Fix Variant time microsecond JSON formatting #10173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion parquet-variant-json/src/to_json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ fn format_time_ntz_str(time: &chrono::NaiveTime) -> String {
0 => format!("{}.{}", base, 0),
_ => {
let micros_str = format!("{:06}", micros);
let micros_str_trimmed = micros_str.trim_matches('0');
let micros_str_trimmed = micros_str.trim_end_matches('0');
format!("{}.{}", base, micros_str_trimmed)
}
}
Expand Down Expand Up @@ -509,6 +509,21 @@ mod tests {
let json = variant.to_json_string()?;
assert_eq!("\"03:25:45.12346\"", json);

let expected = [
(10, "00:00:00.00001"),
(10010, "00:00:00.01001"),
(100000, "00:00:00.1"),
(123450, "00:00:00.12345"),
];

for (micros, expected_json) in expected {
let naive_time =
NaiveTime::from_num_seconds_from_midnight_opt(0, micros * 1000).unwrap();
let variant = Variant::Time(naive_time);
let json = variant.to_json_string()?;
assert_eq!(format!("\"{expected_json}\""), json);
}

let json_value = variant.to_json_value()?;
assert!(matches!(json_value, Value::String(_)));
Ok(())
Expand Down
Loading