[Variant] Implement VariantArray::value for shredded variants#8105
Merged
alamb merged 8 commits intoapache:mainfrom Aug 23, 2025
Merged
[Variant] Implement VariantArray::value for shredded variants#8105alamb merged 8 commits intoapache:mainfrom
VariantArray::value for shredded variants#8105alamb merged 8 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
VariantArray::valuefor shredded variants #8091 .Rationale for this change
Implement
VariantArray::valuefor some more shredded variants(eg. primitive_conversion/generic_conversion/non_generic_conversion).What changes are included in this PR?
macroRulesto a separate moduletype_conversion.rsvariant valueAre these changes tested?
Covered by the existing test
Are there any user-facing changes?
No