Add additional testing coverage for multiple pushdown filters and entirely skipped page#9281
Draft
alamb wants to merge 1 commit intoapache:mainfrom
Draft
Add additional testing coverage for multiple pushdown filters and entirely skipped page#9281alamb wants to merge 1 commit intoapache:mainfrom
alamb wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
Thank you -- I am getting there. I need to add a few more combinations and then I expect to start hitting some of the bugs |
Contributor
Author
|
Update: the tests are coming along, but they are not yet at the state where they reproduce the issue yet (I believe doing so requires more than one arrow predicate) i need to catch up on other reviews, etc today now, but I will get back to these tests tomorrow and hopefully finish them up (and then get back to the actual PR !) |
alamb
changed the title
alamb
force-pushed
the
alamb/tests_for_page_reading
branch
from
42355d0 to
fea7ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As we go about implementing the changes in
I am really struggling to be convinced that the logic for multi-column page skipping is accurate. Thus I am working on adding additional test coverage
What changes are included in this PR?
Add additional test coverage for multi-column row filter predicates
TODO more tests
Are these changes tested?
Yes, with CI
Are there any user-facing changes?
No