Open
Conversation
Contributor
|
Looks interesting - I am wondering if we can't do the same in arrow-rs without relying on a new dependency? |
Dandandan
reviewed
Jan 30, 2026
|
|
||
| impl<'a> KeyAccessor for FixedSizeBinaryAccessor<'a> { | ||
| #[inline(always)] | ||
| fn get_key(&self, index: usize) -> &[u8] { |
Dandandan
reviewed
Jan 30, 2026
| let mut valids: Vec<(u32, u32, u64)> = value_indices | ||
| .into_iter() | ||
| .map(|idx| unsafe { | ||
| // Build (index, 8-byte prefix) tuples for prefix-accelerated comparison sort |
Contributor
There was a problem hiding this comment.
What is the improvement without orasort on this?
Contributor
|
run benchmark sort_kernels |
This comment was marked as outdated.
This comment was marked as outdated.
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
|
run benchmark sort_kernel |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
|
run benchmark sort_kernel |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
|
Seems not to reproduce on the VM 🤔 perhaps machine-dependent |
Contributor
Author
|
I don't understand the benchmarks, can someone explain it to me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Orasort is spliced based on prefix and uses radix sort in spliced chunks.
What changes are included in this PR?
Orasort sorting inclusion, adapting to prefix splices for array buffers.
Are these changes tested?
Yes, tests are already covering it.
In addition to that extra benchmarks are added to demonstrate the gain.
Are there any user-facing changes?
No.
Bench Results (main vs this branch)
Orasort core implementation: https://github.com/psila-ai/orasort
Perf defaults of the Orasort: https://github.com/psila-ai/orasort?tab=readme-ov-file#performance