Add RunEndEncoded array comparator#9368
Open
codephage2020 wants to merge 3 commits intoapache:mainfrom
Open
Conversation
Implement compare_run_end_encoded to support RunEndEncoded arrays by mapping logical indices to physical indices via run_ends and delegating to the child-value comparator.
Contributor
Author
|
@Jefffrey Feel free to give me some advice when you have time. |
Jefffrey
reviewed
Feb 7, 2026
arrow-ord/src/ord.rs
Outdated
| right: &dyn Array, | ||
| opts: SortOptions, | ||
| ) -> Result<DynComparator, ArrowError> { | ||
| let left = left.as_any().downcast_ref::<RunArray<R>>().unwrap(); |
Co-Authored-By: Jeffrey Vo <jeffreyvo@apache.org>
Contributor
Author
|
Thanks for the review @Jefffrey! All three suggestions have been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RunEndEncodedin ord comparator #9360 .Rationale for this change
What changes are included in this PR?
Are these changes tested?
YES
Are there any user-facing changes?
make_comparator now accepts RunEndEncoded arrays